[Microchip TA-100] Fix port + update to cryptoauthlib v3.6.0 by danielinux · Pull Request #9702 · wolfSSL/wolfssl

danielinux · 2026-01-22T17:00:16Z

Description

Rework of TA-100 support to match cryptoauthlib v3.6.0's API. AES-GCM now working.

Fixes zd#20640

Testing

Used wolfDemo board (STM32U585) + TA100 mikrobus module.

Test log (with verbose TA-100 interactions) attached.

test_12a16e6cc.log

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wolfcrypt/src/port/atmel/atmel.c

wolfcrypt/src/signature.c

tests/api.c

wolfcrypt/src/port/atmel/atmel.c

wolfcrypt/src/rsa.c

wolfssl/wolfcrypt/rsa.h

wolfcrypt/test/test.c

wolfcrypt/benchmark/benchmark.c

wolfcrypt/src/port/atmel/atmel.c

dgarske · 2026-02-12T05:49:47Z

Jenkins retest this please.

configure.ac

dgarske · 2026-02-19T21:16:56Z

Jenkins retest this please

dgarske · 2026-02-20T00:15:16Z

@danielinux Please rebase and squash this. Hopefully that will resolve things.

dgarske · 2026-03-04T19:57:59Z

@tmael can you please help get this PR rebased, merge conflicts resolved and ready for merge? This work has been lingering for way too long.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

- Using correct slot ID for AES keys - Adjust IV length - Fallback operations to software for unsupported ECC curves (all tests passing)

ECC384 should be supported in TA-100

…e AS_IF to conditionally run the manual search fallback

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

…kg.m4 is unavailable

dgarske · 2026-02-19T21:19:05Z

wolfcrypt/test/test.c

+        if (ret) {
+            goto exit_rsa;
+        }
+        ret = wc_RsaPublicEncrypt(in, inLen, out, 256, key, &rng);


Let's not duplicate these lines. Just make sure outSz = 256 and use the single call below.

…#ifndef WOLFSSL_MICROCHIP_TA100

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

douzzer

automated test results to resolve (just whitespace/formatting stuff):

[check-source-text] [5 of 55] [c44ab82806]
    configure...   real 0m8.940s  user 0m5.585s  sys 0m4.402s
trailing whitespace:
./wolfcrypt/src/ecc.c:
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 10524) #if defined(HAVE_ECC_CHECK_PUBKEY_ORDER) && !defined(WOLFSSL_SP_MATH)·
./tests/api/test_ecc.c:
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 1373)     !defined(WOLFSSL_MICROCHIP_TA100)·
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 1479)     !defined(WOLFSSL_MICROCHIP_TA100)·
C++-style comments:
./wolfcrypt/src/port/atmel/atmel.c:
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 229)     uint8_t  element_CKA;     //!< contains class, key_type & Algorithm mode
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 230)     uint16_t property;        //!< properties of the element
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 231)     uint8_t  usage_key;       //!< usage key
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 232)     uint8_t  write_key;       //!< write key
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 233)     uint8_t  read_key;        //!< read key
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 234)     uint8_t  permission;      //!< permission of the element usage|write|read|
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 235)                               //delete perm
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 236)     uint8_t  byte7_settings;  //!< Byte 7 attributes use_count|exportable|
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 237)                               // lockable|access_limit
unneeded entries in .wolfssl_known_macro_extras:
WOLFSSL_ATECC508A_NOIDLE
WOLFSSL_ATECC_NO_ECDH_ENC
unrecognized macros used:
ATCA_HAL_I2C
ATCA_TFLEX_SUPPORT
ATECC_DEV_TYPE
TA100_ECC_TRACE
WOLFSSL_MANUALLY_SELECT_DEVICE_CONFIG
WOLFSSL_MICROCHIP_AESGCM
WOLFSSL_NO_DEL_HANDLE
add well-formed but unknown macros to .wolfssl_known_macro_extras at top of source tree.

tmael · 2026-03-06T23:10:17Z

Jenkins retest this please.

douzzer

lingering issues:

[check-source-text] [5 of 56] [06e58f99ec]
    configure...   real 0m8.930s  user 0m5.593s  sys 0m4.379s
C++-style comments:
./wolfcrypt/src/port/atmel/atmel.c:
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 231)     uint8_t  element_CKA;     //!< contains class, key_type & Algorithm mode
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 232)     uint16_t property;        //!< properties of the element
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 233)     uint8_t  usage_key;       //!< usage key
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 234)     uint8_t  write_key;       //!< write key
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 235)     uint8_t  read_key;        //!< read key
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 236)     uint8_t  permission;      //!< permission of the element usage|write|read|
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 237)                               //delete perm
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 238)     uint8_t  byte7_settings;  //!< Byte 7 attributes use_count|exportable|
143722b37c (<tesfa@wolfssl.com> 2025-10-15 16:43:36 -0700 239)

and

[check-configure] [7 of 56] [06e58f99ec]
    bash -n... done.
    shellcheck configure...
In configure.rewritten line 23443:
                as_fn_error $? "CryptoAuthLib found but [ compilation failed. Check config.log for details." "$LINENO" 5 ]
                                                                                                                         ^-- SC2171 (warning): Found trailing ] outside test. Add missing [ or quote if intentional.

For more information:
  https://www.shellcheck.net/wiki/SC2171 -- Found trailing ] outside test. Ad...
   real 0m10.408s  user 0m10.142s  sys 0m0.264s
    scenario started 2026-03-09T16:46:20.197731Z, real elapsed 0m10.486447s
    check-configure fail_analysis

Copilot AI review requested due to automatic review settings January 22, 2026 17:00

Copilot started reviewing on behalf of danielinux January 22, 2026 17:00 View session

This comment was marked as outdated.

Sign in to view

danielinux self-assigned this Jan 22, 2026

danielinux force-pushed the ta100_2025 branch 2 times, most recently from 03c4ab8 to 199c152 Compare February 10, 2026 12:54

danielinux requested a review from Copilot February 10, 2026 13:08

Copilot started reviewing on behalf of danielinux February 10, 2026 13:09 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

danielinux assigned wolfSSL-Bot and unassigned danielinux Feb 10, 2026

SparkiDev assigned danielinux Feb 11, 2026

dgarske requested a review from tmael February 12, 2026 05:49

dgarske requested changes Feb 18, 2026

View reviewed changes

configure.ac Show resolved Hide resolved

danielinux force-pushed the ta100_2025 branch from f6c5f77 to 81086ff Compare February 19, 2026 08:24

danielinux assigned tmael Feb 19, 2026

danielinux force-pushed the ta100_2025 branch from 81086ff to 36b0e21 Compare February 20, 2026 19:30

dgarske unassigned danielinux Mar 4, 2026

Copilot AI review requested due to automatic review settings March 5, 2026 01:13

tmael force-pushed the ta100_2025 branch from 36b0e21 to 97a7359 Compare March 5, 2026 01:13

Copilot AI reviewed Mar 5, 2026

View reviewed changes

tmael and others added 5 commits March 5, 2026 15:23

TA100: Microchip Trust Anchor support RSA/ECC

143722b

TA100: follow-up changes (squash after 4e64cb5)

b61d729

[TA-100] Fixed GMAC, AES-GCM, AES, ECC

b50fecc

- Using correct slot ID for AES keys - Adjust IV length - Fallback operations to software for unsupported ECC curves (all tests passing)

Reverted changes to fallback ECC

3056e97

ECC384 should be supported in TA-100

[TA-100] Fixed ECC384. Adding RSA.

648317c

danielinux and others added 3 commits March 5, 2026 15:23

[TA-100] Fixed RSA keygen/sign/verify, tests

e0beffe

Close PKG_CHECK_MODULES with a no-op failure action and use a separat…

4a25381

…e AS_IF to conditionally run the manual search fallback

[TA-100] Fix build/test regressions in non-TA100 builds

6289e72

Copilot AI review requested due to automatic review settings March 5, 2026 23:30

tmael force-pushed the ta100_2025 branch from 97a7359 to 6289e72 Compare March 5, 2026 23:30

Copilot AI reviewed Mar 5, 2026

View reviewed changes

wraps PKG_CHECK_MODULES with m4_ifdef so it's silently skipped when p…

f2a86f7

…kg.m4 is unavailable

dgarske added the For This Release Release version 5.9.0 label Mar 6, 2026

dgarske previously approved these changes Mar 6, 2026

View reviewed changes

Removed the dead #ifdef WOLFSSL_MICROCHIP_TA100 block (it was inside …

b9c41a2

…#ifndef WOLFSSL_MICROCHIP_TA100

Copilot AI review requested due to automatic review settings March 6, 2026 00:48

tmael dismissed dgarske’s stale review via b9c41a2 March 6, 2026 00:48

Copilot AI reviewed Mar 6, 2026

View reviewed changes

douzzer added the Staged Staged for merge pending final test results and review label Mar 6, 2026

douzzer requested changes Mar 6, 2026

View reviewed changes

douzzer removed the Staged Staged for merge pending final test results and review label Mar 6, 2026

Fix formatting

a9f3497

tmael requested a review from douzzer March 6, 2026 18:43

douzzer added the Staged Staged for merge pending final test results and review label Mar 9, 2026

douzzer requested changes Mar 9, 2026

View reviewed changes

douzzer removed the Staged Staged for merge pending final test results and review label Mar 9, 2026

Conversation

danielinux commented Jan 22, 2026

Description

Testing

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgarske commented Feb 12, 2026

Uh oh!

Uh oh!

dgarske commented Feb 19, 2026

Uh oh!

dgarske commented Feb 20, 2026

Uh oh!

dgarske commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

dgarske Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

douzzer left a comment

Choose a reason for hiding this comment

Uh oh!

tmael commented Mar 6, 2026

Uh oh!

douzzer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants